Hi!

On 11/06/2014 04:26 PM, Cyril Hrubis wrote:
> Hi!
>> In iproute2 whose version is earlier than v2.6.39, ip
>> command doesn't support netns object. In this condition,
>> running three cases (netns_devices.sh, netns_devices2.sh
>> and netns_isolation.sh) will exit with TFAIL. It is not
>> suitable, so fix these cases' exit status with TCONF.
>
> Again, it would be better to compare the versions rather than grepping
> the output. And for this case it may even make sense to put the check
> into a common script and source it in all the tests that needs it.
>
> I.e. create netns_helper.sh and put the check in there.
>


Got it. Thanks for your suggestion.
After confirming the iproute version which is suitable for these cases, 
I will send a patch later.
Thanks!


Regards,
Xing Gu

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to