On Tue 11-11-14 15:09:18, Cyril Hrubis wrote:
> Hi!
> > > > Verify that when inode has an ignore mask set, it is properly reflected
> > > > when notifying a mountpoint. The test verifies fix "fanotify: Fix 
> > > > notification
> > > > of groups with inode & mount marks" in the Linux kernel.
> > > > 
> > > > Signed-off-by: Jan Kara <j...@suse.cz>
> > > 
> > > Pushed with small change to get rid of another signed vs unsigned
> > > comparsion warning.
> >   Yeah. BTW those warnings are pretty annoying and the number of false
> > positives is IHMO too large for the warning to be useful...
> 
> Well they come with the gcc -W flag (nowadays called -Wextra). We may be
> able to disable these with -Wno-sign-compare but don't want to play
> whack a mole trying to figure out which warnings are useful. I doubt
> that this is worth the effort and since we do not use -Werror these are
> just mildly annoying. Or do you have a better idea?
  Actually -Wextra doesn't turn on that many warnings (like 12) so it
doesn't seem that hard to turn off the ones you don't find useful. But if
you find warnings about signed vs unsigned comparison useful, just leave
them in, you are the maintainer responsible for the code ;)

                                                                Honza
-- 
Jan Kara <j...@suse.cz>
SUSE Labs, CR

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to