On 12/02/2014 10:12 PM, Cyril Hrubis wrote: > Hi! >>>> + } else { >>>> + if (cur_ipver < spe_ipver) >>>> + ret = -1; >>>> + else if (cur_ipver == spe_ipver) >>>> + ret = 0; >>>> + else >>>> + ret = 1; >>>> + } >>> >>> Again why bother with return value when all the testcases just needs to >>> know if ip is newer than some version? >>> >> >> I do this in order to provide more choices for users, like tst_kvercmp. >> Is it necessary? If it is not, I will send a new patch. Thanks! > > Sorry, I've forgot to answer this one. > > I would stick to the simpler version unless there is a need for the more > complex interface. Generally we should do things as simple as possible. >
Got it. I will send a new patch later. Thanks! Regards, Xing Gu ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list