Hi,
> > and if I make codes like this, the next line's style will not be consistent
> > to it:
> > + if (!tst_system("mkfs.btrfs 2>&1 | grep '\\-f ' >/dev/null")) {
> > tst_resm(TINFO, "Appending '-f' flag to mkfs.%s",
> > fs_type);
>
> I do not get what is inconsistent here. The line for the if condition is
> 79 chars long that way, the next line with tst_resm would be more than
> 80 therefore it should continue on the next line. It's that simple.
My fault. My vim got the config "tabstop=4" and the following lines are both 70
chars:
if (!tst_system("mkfs.btrfs 2>&1 | grep '\\-f ' >/dev/null")) {
tst_resm(TINFO, "Appending '-f' flag to mkfs.%s", fs_type);
Now I think I understood a little why python suggests use space instead of tab.
Thanks for reviewing, I will post the new patch with your advice.
Best regards,
--
George Wang 王旭
Kernel Quantity Engineer
Red Hat Software (Beijing) Co.,Ltd
IRC:xuw
Tel:+86-010-62608041
Phone:15901231579
9/F, Tower C, Raycom
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
