Hi! > -if [ ! -d "$Where" ]; then > - if [ -e "$Where" ]; then > - echo "Test directory \"$Where\" exists but is not a directory." > - exit 1 > - fi > - mkdir -m 777 "$Where" > - if [ ! -d "$Where" ]; then > - echo "Test directory \"$Where\" can not be created." > - exit 1 > - fi > -fi > +tst_tmpdir > +TST_CLEANUP=cleanup > + > +chmod 777 $(pwd)
Hmm, we do chmod 777 for the TMPDIR in the C test library. I guess that it will be better to move the chmod to test.sh and omit it here. The rest of the patchset looks good to me. -- Cyril Hrubis chru...@suse.cz ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
