On Tue, Mar 17, 2015 at 02:32:16PM +0100, Cyril Hrubis wrote: > Hi! > > Running llseek01 testcase as unprivileged user currently fails. > > > > njoly@raya [syscalls/llseek]> ./llseek01 > > llseek01 1 TPASS : Functionality of llseek() on tmp_file successful > > llseek01 2 TBROK : llseek01.c:223: Cannot reset max. file size using > > setrlimit > > llseek01 3 TBROK : llseek01.c:223: Remaining cases broken > > > > This issue comes from cleanup function that tries to restore > > previously altered file size limit. But this fails as unprivileged > > because it cannot raise the hard limits. > > Either we remove the restoration or add tst_require_root() to > setup(), I'm fine with either one.
IMO root credentials is a little overkill ... This functionality can be tested with unprivileged rights. We should keep requirements as small as possible. > However this patch is incomplete because it > removes only the restoration part but leaves the then unused getrlimit() > that gets the original limit in setup, this should be removed (with the > global rlp_orig variable) as well. Right. Will submit a new patch. -- Nicolas Joly Biology IT Center Institut Pasteur, Paris. ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
