Hi!
On Wed, 2015-04-22 at 14:47 +0200, Cyril Hrubis wrote:
> Hi!
> > +SAFE_CALL()
> > +{
> > + $@ > /dev/null 2>&1
> > + if [ $? -ne 0 ]; then
> > + tst_brkm TBROK "$@ failed"
> > + fi
> > +}
> > +
> > +SAFE_CALL_REDIRECT()
> > +{
> > + $@
> > + if [ $? -ne 0 ]; then
> > + tst_brkm TBROK "$@ failed"
> > + fi
> > +}
>
> Looks good but the names are a bit confusing. The SAFE_CALL does
> redirect the output while SAFWE_CALL_REDIRECT does not.
>
If *users* want to redirect the output they need use SAFE_REDIRECT. :-/
> Maybe naming the first SAFE_SILENT() and the second just SAFE() would be
> better. And because this is not too much similar to the C interface we
> can name it even more differently. Shorthand for "run or die" would be
> ROD_SILENT and ROD.
ROD and ROD_SILENT are OK.
Thank you very much.
Best regards,
Zeng
>
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
