Hi!
> Increase the sleep time after online_cpu to
> adapt embedded hardware.
>
> Signed-off-by: Chase Qi <chase...@linaro.org>
> ---
> .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh | 13
> +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> index bb0e896..f088d25 100755
> --- a/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> +++ b/testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug05.sh
> @@ -5,6 +5,7 @@
>
> export TCID="cpuhotplug05"
> export TST_TOTAL=1
> +export LC_TIME="POSIX"
>
> # Includes:
> . test.sh
> @@ -80,11 +81,11 @@ TST_CLEANUP=do_clean
> until [ $LOOP_COUNT -gt $HOTPLUG05_LOOPS ]; do
>
> # Start up SAR and give it a couple cycles to run
> - sar 1 0 &>/dev/null &
> + sar 1 &>/dev/null &
> sleep 2
> if ps -C sar &>/dev/null; then
> pkill sar
> - sar -P ALL 1 0 > $TMP/log_$$ &
> + sar -P ALL 1 > $TMP/log_$$ &
> else
> sar -P ALL 1 > $TMP/log_$$ &
> fi
> @@ -92,14 +93,14 @@ until [ $LOOP_COUNT -gt $HOTPLUG05_LOOPS ]; do
> SAR_PID=$!
>
> # Verify that SAR has correctly listed the missing CPU
> - while ! awk '{print $9}' $TMP/log_$$ | grep -i "^0.00"; do
> + while ! awk '{print $8}' $TMP/log_$$ | grep -i "^0.00"; do
Ah, it took me a while to figure out that the output of sar is different
based on LC_TIME. Can you please describe the changes more verbosely
than "fix invalid sar usage" in the commit message?
Otherwise the changes looks good.
--
Cyril Hrubis
chru...@suse.cz
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
