From: Manjeet Pawar <manjee...@samsung.com>
Subject: [PATCH] testcases/kernel/device-drivers/usb/tusb/tusb.c: Fix possible 
NULL pointer derefrence

pdev was accessed before its NULL check, this patch fixes this.

Signed-off-by: Manjeet Pawar <manjee...@samsung.com>
Signed-off-by: Yogesh Gaur <yn.g...@samsung.com>
---
 testcases/kernel/device-drivers/usb/tusb/tusb.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/device-drivers/usb/tusb/tusb.c 
b/testcases/kernel/device-drivers/usb/tusb/tusb.c
index 774600a..258070a 100644
--- a/testcases/kernel/device-drivers/usb/tusb/tusb.c
+++ b/testcases/kernel/device-drivers/usb/tusb/tusb.c
@@ -386,14 +386,15 @@ static int test_hcd_probe()
        int rc;
        struct usb_hcd *hcd = NULL;
        struct pci_dev *pdev = ltp_usb.pdev;
-       struct pci_device_id *id =
-           (struct pci_device_id *)pdev->driver->id_table;
+       struct pci_device_id *id = NULL;
 
        if (!pdev) {
                printk("tusb: pdev pointer not set\n");
                return 1;
        }
 
+       id = (struct pci_device_id *)pdev->driver->id_table;
+
        if (!id || !id->driver_data) {
                printk("tusb: id_table not set\n");
                return 1;
-- 
1.7.9.5


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to