Hi!
> @@ -110,9 +111,13 @@ const char **splitstr(const char *str, const char 
> *separator, int *argcount)
>               cur_tok = strtok(NULL, separator);
>               if (num_toks == max_toks) {
>                       max_toks += 20;
> -                     arg_array =
> -                         (char **)realloc((void *)arg_array,
> -                                          sizeof(char *) * max_toks);
> +                     if((arg_array = realloc((void *)arg_array,sizeof(char 
> *) * max_toks)) == NULL){
> +                             fprintf(stderr, "realloc: New memory allocation 
> failed \n");
> +                             free(arg_array);
> +                             free(arg_string);
> +                             exit(1);
> +                     }
> +

These lines does not conform to LKML coding style.

There should be space before the opening curly brace '{', spaces after
coma, etc.

You can use checkpatch.pl shipped with linux kernel source to check your
patches before sending them.

-- 
Cyril Hrubis
chru...@suse.cz

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to