On 06/09/2015 01:54 PM, Cyril Hrubis wrote:
> Hi!
>> Now we verify the exit code of the second test case. We did not
>> do this previously, and it was a bug.
>>
>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmansk...@oracle.com>
>> ---
>>   testcases/kernel/fs/acls/acl_test01 |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/testcases/kernel/fs/acls/acl_test01 
>> b/testcases/kernel/fs/acls/acl_test01
>> index be88aa8..0f050b9 100755
>> --- a/testcases/kernel/fs/acls/acl_test01
>> +++ b/testcases/kernel/fs/acls/acl_test01
>> @@ -228,7 +228,8 @@ else
>>      chown $TEST_USER1 $FILE_ACL
>>      chown $TEST_USER1 $FILE_ACL_LINK
>>
>> -    su $TEST_USER1 -c "$0"
>> +    su $TEST_USER1 -c "$0" &
>> +    tst_record_childstatus $!
>
> We should probably wrap the su into a script that makes sure that the
> return value is compatible with LTP. Because it may set bogus test
> return status if su reported anything else than 0 or 1.

Ehm, but -c "$0" will execute the same script which, in turn, will exit 
using tst_exit.


>
> Or we may add just another function into test.sh that would work
> similariry to tst_record_childstatus but that will normalize the return
> value. I.e. 0 == TPASS, anything else TFAIL.
>

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to