Hi! On Mon, 2015-06-08 at 15:57 +0200, Cyril Hrubis wrote: > Hi! > > > I don't get why we multiply the numbers, substract them and then divide > > > them again. Can't we just substract them? > > > > This is for the conversion of measurement units. > > For example: > > We may get the output from 'df', 172k as subtrahend and 11M as minuend. > > If we want to do subtract. We should convert them to the same unit > > first. > > Does that actually happen?
To be honest. It happens. But I think your comments is very reasonable. Indeed, these code make others confused. I have rewritten them. Best regards, Zeng > > Looking at the code the sub() is called from df_verify() that calls df > always with exactly same parameters twice so we always end up with > matching units or am I mistaken? > > > > Also does this work for other filesystems than ext2? It may be a good > > > idea to run the test for a few more filesystems as well. We may add a > > > parameter which fs to use and add entries as: > > > > > > > Hmm, this is a good idea. > > Nowadays, I am thinking about ext3 and ext4, but I know very few about > > other filesystems. Are you OK that I send you the new patches about > > them(ext2, ext3 and ext4)? > > Sounds as a good start. If you add an parameter to specify fs to test we > can easily extend it for any other fs as well later on. > ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
