Hi! On 06/12/2015 09:06 AM, Cui Bixuan wrote: > On 2015/6/9 21:33, Cyril Hrubis wrote: >> Hi! >> I would rather see these being added one test per file with some shared >> code in sourced library. >> >> If there is a simple script that executes a lot of testcases it harder >> to debug and the results are binary (FAIL/PASS for a group of test) >> instead of actual testcases. >> > Hi, > Thank you for your reply. I resend patches to cleanup the iptables > testcase and add some testcases for it. > But I don't have good idea for adding one test per file > with some shared code :-( . Hope someone give some advice for me.
Probably you could do the following steps: 1. rename the existed iptables_tests.sh to iptables01.sh, don't forget to update runtests/ with the new test name; 2. extract common code from iptables01.sh to iptables_lib.sh (cleanup/change or add new code there), and source the new lib in iptables01.sh; 3. Then add your new test-cases to iptables02.sh and source iptables_lib.sh as well. Please look at 'network/dhcp' tests as an example. Thanks, Alexey ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
