On 06/16/2015 03:24 PM, Zeng Linggang wrote: > > -char *filetmpl = "/tmp/%.*s_XXXXXX"; > +static const char *filetmpl = "/tmp/%.*s_XXXXXX"; >
Sorry, I missed that one in the previous review, could you use tst_tmpdir()? So here should be "%.*s_XXXXX". There is /tmp/test file that left after the test, it could be fixed if we hadn't used absolute path in the patch. I would print it in case of test-case failure. > > -int runcc(char *tname, char *filename0, char *program) > +static int runcc(char *tname, char *filename0, char *program) If we don't use return value - why it is still "int runcc()"? Also please change perror() and exit(1) to LTP library functions. Thanks, Alexey ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
