Hi!
> > In commit 841c0eebc50068d6595b97b50ae0ee8e8f57c8ca:
> > We changed "sar 1 0" to "sar 1", but it make the test not
> > work well before 'sysstat-8.1.4(include sar)'.
> 
> The old syntax does not work with newer sar. So the correct fix here is
> to do runtime check and change parameters accordingly.

Ah, sorry for replying before I finished my coffee...

The code does exactly that but I would be happier if we had the fi only
in one place, something like:

sar 1 0 > /dev/null &
pid=$!

if kill -0 $pid 2> /dev/null; then
        kill $pid
        SAR_PARAMS="1 0"
else
        SAR_PARAMS="1"
fi

...

sar $SAR_PARAMS ...

-- 
Cyril Hrubis
chru...@suse.cz

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to