Hi!

On 2015/08/03 23:48, Cyril Hrubis wrote:
> Hi!
>> +static void verify_fchown(void)
>> +{
>> +    uid_t tuid = 1000;
>> +    gid_t tgid = 1000;
>> +
>> +    TEST(fchown(fd, tuid, tgid));
> 
> Any reason why don't we pass the numbers directly to the call?
> 
> I.e. TEST(fchonw(fd, 1000, 1000)); ?
> 
> Otherwise this looks good.
> 

This looks better indeed, thanks!


Best Regards,
Guangwen Feng

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to