Hi,

On Tue 11-08-15 16:14:32, Cyril Hrubis wrote:
> Pushed with following changes:
> 
> * Added GPL header at the start of the file
> 
> * Removed cleanup parameter from SAFE calls in child
>   because if one of the calls in child fails the temporary
>   directory would be deleted, then parent would attempt to
>   remove the directory and that will fail horribly.

Ah, good point.

> * Moved to body of the test to separate function to spare
>   some indentation.
> 
> * Used tst_fork() instead of fork() (flushes userspace stdio buffers
>   before fork, otherwise messages from test may end up duplicated
>   several times)
 
Ok, good, will know for next time.

> * Used ltp_syscall() instead of syscall() which handles ENOSYS etc.

And this one as well.

> * Added inotify06 binary to gitignore.

I keep forgetting about this :)

                                                                Honza
-- 
Jan Kara <j...@suse.com>
SUSE Labs, CR

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to