On 08/11/2015 09:21 PM, Cyril Hrubis wrote: >> +for m in $modes; do >> + tst_resm TINFO "add $virt_type with mode '$m'" >> + >> + virt_add ltp_v0 mode $m > /dev/null 2>&1 >> + if [ $? -ne 0 ]; then >> + tst_resm TCONF "iproute or kernel doesn't support mode '$m'" > shouldn't we rather call continue here, since we issued > TCONF but without it we will proceed with PASS/FAIL from > the virt_add_delete_test. Or am I mistaken?
What I have in mind here is to perform add/delete test-case with different parameters, in this case different modes. So the total steps are the same but if option is supported, use it on some steps, otherwise proceed without it. May be the message should be changed to something like: tst_resm TINFO "'$m' mode not supported by iproute/kernel, use default" Thanks, Alexey ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
