Hi!
> > Also do we want to assert that the dummy0 device is listed in the /sys
> > inside the namespace?
>
> Don't you think that this is sufficient ?
>
> ns_exec $NS_HANDLE ip link add dummy0 type dummy || \
>
> tst_brkm TBROK "failed to add a new dummy device"
We are testing sysfs in network namespaces, so I'm tepmted to do
something as:
if [ -d /sys/class/net/dummy0 ]; then
tst_resm TPASS ...
else
tst_resm TFAIL ...
fi
After sysfs is mounted.
> >> Anyway, one thing you can do before pushing the patch is to remove
> >> kill -9 $NS_HANDLE
> >> command from the test code, as this is done inside cleanup function.
> >
> > Killing it twice once in the test and once in the cleanup is mistake as
> > well. Since the NS_HANDLE is pid and it may have been reused if there
> > was a lot of forking done on the system meanwhile. Which is unlikely but
> > still possible.
>
> True. Will you remove that kill command on pushing or should I resend the
> patch v4 ?
No need to resend, I will fix that before pusing.
--
Cyril Hrubis
chru...@suse.cz
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
