Hi Cyril!

I try to build LTP with POSIX testsuite and run "make clean". As a result 
"testcases/open_posix_testsuite" is no cleaned properly. It happens because 
that directory is filtered by "make" here:
https://github.com/linux-test-project/ltp/blob/master/testcases/Makefile#L33

And it's filtered because WITH_OPEN_POSIX_TESTSUITE symbol is not defined when 
you run "make clean". And it's not defined because "config.mk" and 
"features.mk" are not included for "clean" target:
https://github.com/linux-test-project/ltp/blob/master/include/mk/env_pre.mk#L98

So I've decided to include these configuration files for "clean" target too. 
I've supposed that "clean" target may be invoked even if those files don't 
exist so I've used error suppression mechanism.

Regards,
Yuriy Kolerov


-----Original Message-----
From: Cyril Hrubis [mailto:chru...@suse.cz] 
Sent: Monday, September 07, 2015 6:30 PM
To: Yuriy Kolerov
Cc: ltp-list@lists.sourceforge.net; anton.kole...@synopsys.com; 
francois.bed...@synopsys.com
Subject: Re: [LTP] [PATCH] Enable including config.mk and features.mk for 
*clean targets

Hi!
> It's necessary for correct cleaning. E.g. open_posix_testsuite is not 
> cleaned without including these .mk files. However it's not an error 
> if these files does not exist while cleaning.

What problem are you trying to fix? I cannot image how we can get into state 
where the mk files generated by configure does not exist but the tree is not 
clean. Unless one deletes them manually of course.

--
Cyril Hrubis
chru...@suse.cz

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to