On Tue, Feb 19, 2013 at 4:37 PM, Sedat Dilek <[email protected]> wrote: > On Tue, Feb 19, 2013 at 1:25 PM, Petr Machata <[email protected]> wrote: >> Sedat Dilek <[email protected]> writes: >> >>> On Sat, Feb 16, 2013 at 3:58 PM, Oliver Spornitz <[email protected]> >>> wrote: >>>> I applied the three patches to the branch ospornit/move_mipsel on top >>>> of the current master. >>> >>> Cherry-picking the 3 patches to ltrace-0.7 branch worked nicely! >>> Petr, can you apply (cherry-pick) them after merging into master? >> >> This is a cleanup that shouldn't have any visible effect for users. >> I don't consider it appropriate for 0.7.x. >> > > The first thing I did not understand when looking at the Freetz ltrace > package was WTF-arch=mips or =mipsel. > So there was this symlink from mipsel->mips in the source-code. > If you look at the kernel-archives you see arch=mips. > That's why I changed in my local Freetz GIT repo to: > > ARCH="$(KERNEL_ARCH)" \ > > So this stuff might be a "cleanup" in your eyes, but for me this is to > correct what $ARCH really should be for ltrace in the MIPS world. > > As the 3 patches can be easily cherry-picked, there is nothing > speaking against to apply them. > > If your philosphy/policy is to only include real BUGFIXES into a > ltrace-x.y release, please document this! > > Furthermore, I highly appreciate that you put a NOTE in the > commit-changelog of patches taken from ltrace-upstream to any BUGFIX > release. This is common usage for example stable Linux-kernels. So > people can follow what's happening. > > EXAMPLE from [1]: > > "commit 1de63d60cd5b0d33a812efa455d5933bf1564a51 upstream." > > BTW, when are you planning a v0.8.0 release? > > With latest ltrace-upstream GIT I get this: > > configure: updating cache > /home/wearefam/src/freetz/freetz-git/source/target-mipsel_uClibc-0.9.32.1/config.cache > configure: creating ./config.status > config.status: error: cannot find input file: `Makefile.in' > > ERROR: Build failed. > make: *** > [source/target-mipsel_uClibc-0.9.32.1/ltrace-0.7.90+gitbc0de43/.configured] > Error 1 > > I must check if this is a local problem or comes from ltrace. >
Damn, it was a local problem: $ rm -f ./source/target-mipsel_uClibc-0.9.32.1/config.cache - Sedat - > - Sedat - > > [1] > http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=commitdiff;h=a7a878d102299bec638233e6a8ab679ce89a1c24 > >> Thanks, >> PM _______________________________________________ Ltrace-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel
