On Thu, Oct 10, 2013 at 7:19 AM, Petr Machata <[email protected]> wrote: > I was about to apply this (and actually did, locally), but the > compilation fails on i386, so I won't push this. > >> + /* Verify that we can cast arch_addr_t to unw_word_t. */ > > Actually, that we can safely cast arch_addr_t* to unw_word_t*. > >> + fprintf(options.output, " > %s(%s+0x%lx) [%p]\n", >> + lib_name, fn_name, function_offset, >> ip); > > 0x%lx expects unsigned long argument, but on 32-bit systems, > function_offset is (typedef'd) unsigned int. I think the reasonable > solution, now that we have the static assert up there, is to make > function_offset arch_addr_t as well, and replace 0x%lx with %p. >
Hey Petr, sorry for not testing it on 32bit (the new patch is tested on a 32bit system). Let me know if there is any problem with it. Luca _______________________________________________ Ltrace-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel
