Petr Machata <[email protected]> писал в своём письме Fri, 10 Apr 2015 15:36:17 +0300:

Oh the wonders of C.

I'm looking at name2lens--it only ever sets *own_lensp to 0.  Any
opinions about this?

Looks good to me.

-       int own_lens;
-       struct lens *lens = name2lens(str, &own_lens);
+       struct lens *lens = name2lens(str);
+       // N.B.: LENS is not owned, and should not be destroyed.
+

Though I'd put the comment on the function, not here.

Roman.

_______________________________________________
Ltrace-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel

Reply via email to