Thierry [email protected] <[email protected]> writes:
> We all agree that new features like dwarf support should be officially > integrated in a release. > However today the few tests I have made show that dward test is > providing not coherent results on x86_64 so I believe that time is > missing to have a more complete testing release ... > At least on my side I need a few days to fix ppc64 problems with dwarf > test.... ppc64le being in good shape > I would be glad to hear from ARM side... Hi. Sorry it took so long to reply. Are the DWARF tests the main blocker here? There're more features the new code has: backtraces for instance. I just looked at the dwarf tests, and I see a number of failures that have appeared because my libc was updated between when the tests were written and now. One issue was a crash, that is fixed by the attached patch. A number of other libc changes cause test failures, but I haven't fixed those yet. I will probably simply disable those test chunks. Are you having trouble on your ppc64 box still? Is it worth it for me to try to replicate that in emulation?
>From 192e0a678bd628ef2faef638c50e70129128a6fb Mon Sep 17 00:00:00 2001 From: Dima Kogan <[email protected]> Date: Fri, 8 Apr 2016 16:12:25 -0700 Subject: [PATCH] void struct members are now ignored Previously the dwarf parser would crash when encountering such a thing --- dwarf_prototypes.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dwarf_prototypes.c b/dwarf_prototypes.c index bfac177..0d53b8b 100644 --- a/dwarf_prototypes.c +++ b/dwarf_prototypes.c @@ -616,6 +616,11 @@ static struct arg_type_info *get_structure(Dwarf_Die *parent, complain(&die, "Couldn't parse type from DWARF data"); CLEANUP_AND_RETURN_ERROR(NULL); } + if (member_type->type == ARGTYPE_VOID) { + complain(&die, "Struct member has void type. " + "Giving up on this structure"); + CLEANUP_AND_RETURN_ERROR(NULL); + } if (type_struct_add(result, member_type, newly_allocated_member_type) != 0) { complain(&die, "Couldn't add type to struct"); -- 2.1.4
_______________________________________________ Ltrace-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel
