Hi!Thanks bringing all the problems with tests to surface! I have a few comments concerning the suggested patch. I'll start with the one which looks most messy.
It's a pity to unconditionally disable all the tests which depend on the presence of debuginfo for glibc.
Of course, from one side, some of these 4 functions used for tests (ftell, usleep, nanosleep, strlen) have recently started to produce less valuable test results than in former glibc versions -- see https://github.com/dkogan/ltrace/commit/9193ab324173439f2140174ec43434e43081393a for an explanation.
On the other side, the debuginfo for glibc is not always available, and this presents a problem for accurate packaging of ltrace.
But these are different problems, and solving them by simply commenting out all the tests is not the interesting solution.
As for the first problem, I'd replace strlen and nanosleep (which now give non-valuable results) with some other glibc functions. I'd even leave the tests with strlen and nanaosleep in the old form as known "X-FAIL" tests (but I'm not sure that the testing system has such a notion), so that they remain as a challenge for future developers who could develop the technique of analyzing the calls and reading the debuginfo in such complicate cases. (What would gdb show?)
Some of tests with these 4 funcions test some other features of ltrace in combination with DWARF-reading, so that they still are interesting regardless of the problesm with strlen and nanosleep. (That's why I have called this patch messy: it's difficult to undestand from the patch which features are excluded from testing by it.)
As for the second problem, I'd simply add a switch which can be turned on to run the tests in a system where the debuginfo for glibc is installed.
(I'm including this individual patch in my message in the hope that it would be easier to follow what is going on in this discussion when the patch is near.)
-- Best regards, Ivan
>From 27d4c892c22d4848f9ffdb6df143505a1b5885a6 Mon Sep 17 00:00:00 2001 From: Grigory Ustinov <[email protected]> Date: Wed, 22 Nov 2017 10:17:15 +0300 Subject: [PATCH 5/5] Disable glibc-core-debuginfo tests --- testsuite/ltrace.main/dwarf.exp | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/testsuite/ltrace.main/dwarf.exp b/testsuite/ltrace.main/dwarf.exp index faa6d39..aa148da 100644 --- a/testsuite/ltrace.main/dwarf.exp +++ b/testsuite/ltrace.main/dwarf.exp @@ -9,7 +9,6 @@ # built without elfutils. You'll still be able to run this test directly (with # runtest) and see it fail - proc run_dwarf_test {ref_output ltrace_opts} { global srcdir subdir objdir @@ -132,7 +131,6 @@ run_dwarf_test $ref_output_e $ltrace_opts_e # was called and not anything particular about the arguments set ltrace_opts_e {"-l" "libc.so*"} set ref_output_e [subst -nocommands -novariables { -dwarf->usleep(33) * = 0 dwarf->nanosleep(.* } ] run_dwarf_test $ref_output_e $ltrace_opts_e @@ -141,23 +139,21 @@ set ltrace_opts_e {"-L" "-x" "@libc.so*[email protected]"} set ref_output_e [subst -nocommands -novariables { [email protected](0x[0-9a-z]* [email protected](.* [email protected](33 <unfinished ...> [email protected](.* -<... usleep resumed> ) * = 0 [email protected](.* } ] run_dwarf_test $ref_output_e $ltrace_opts_e # Make sure the DWARF filtering and the alias finding work well together -set ltrace_opts_e {"-L" "-x" "[email protected]*"} -set ref_output_e [subst -nocommands -novariables { [email protected](0x[0-9a-z]*) * = -1 -} ] -run_dwarf_test $ref_output_e $ltrace_opts_e - -set ltrace_opts_e {"-L" "-x" "*[email protected]*"} -set ref_output_e [subst -nocommands -novariables { [email protected](0x[0-9a-z]*) * = -1 -} ] -run_dwarf_test $ref_output_e $ltrace_opts_e +#set ltrace_opts_e {"-L" "-x" "[email protected]*"} +#set ref_output_e [subst -nocommands -novariables { +#[email protected](0x[0-9a-z]*) * = -1 +#} ] +#run_dwarf_test $ref_output_e $ltrace_opts_e + +#set ltrace_opts_e {"-L" "-x" "*[email protected]*"} +#set ref_output_e [subst -nocommands -novariables { +#[email protected](0x[0-9a-z]*) * = -1 +#} ] +#run_dwarf_test $ref_output_e $ltrace_opts_e -- 2.10.4
_______________________________________________ Ltrace-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel
