(Sorry, I missed the correct patch which I am commenting in the previous
message. It also had a wrong title. Now I'm correcting this by repeating
that message with the right subject and the discussed patch included.)
Hello!
It would be more natural just to declare this test (of a feature which has
not yet been implemented) as "X-FAIL"; I mean: which is expected to fail.
It will always be run, and in future, if something changes, we'll notice
the change in the test results and act
accordingly.
Does the testing system (dejagnu?) has a way to say that a test is
expected not to pass, but to fail (and not count it as a real failure)?
(A switch like a define is better suited to reflect the features of the
environment, external to our project; as an advice for the other patch:
perhaps, whether we have the debuginfo for glibc available could be
reflected by a "switch".)
--
Best regards,
Ivan
>From 685324799ab7d97650e584f83595f50647ad9749 Mon Sep 17 00:00:00 2001
From: Grigory Ustinov <[email protected]>
Date: Fri, 17 Nov 2017 19:33:23 +0300
Subject: [PATCH 2/5] Fix FAIL in wchar.exp test
turn off test due Ltrace doesn't support long double
see: etc/libc.so-types.conf:XXX ltrace misses long double and long long support
---
testsuite/ltrace.minor/wchar.exp | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/testsuite/ltrace.minor/wchar.exp b/testsuite/ltrace.minor/wchar.exp
index ab909de..d7e8f4f 100644
--- a/testsuite/ltrace.minor/wchar.exp
+++ b/testsuite/ltrace.minor/wchar.exp
@@ -18,6 +18,7 @@
set bin [ltraceCompile {} [ltraceSource c {
#define _XOPEN_SOURCE
+ #define LONGDOUBLETEST_DISABLE
#include <sys/time.h>
#include <assert.h>
#include <locale.h>
@@ -124,7 +125,9 @@ set bin [ltraceCompile {} [ltraceSource c {
{ wchar_t *ptr = NULL; wcstod(wcsstr(wbuf, L"â¢") + 2, &ptr); }
wcsncpy(wbuf, L"1234â¢", 64);
{ wchar_t *ptr = NULL; wcstof(wbuf, &ptr); }
+ #ifndef LONGDOUBLETEST_DISABLE
{ wchar_t *ptr = NULL; wcstold(wbuf, &ptr); }
+ #endif
{ wchar_t *ptr = NULL; wcstol(wbuf, &ptr, 10); }
{ wchar_t *ptr = NULL; wcstoll(wbuf, &ptr, 10); }
{ wchar_t *ptr = NULL; wcstoul(wbuf, &ptr, 10); }
@@ -195,7 +198,9 @@ ltraceMatch [ltraceRun -F $srcdir/../etc/ -- $bin] {
{{^wcstod\(".*»", ".*»"\).*= [0-9]+} == 1}
{{^wcsncpy\(.*, "1234â¢", 64\).*= .*} == 1}
{{^wcstof\("1234â¢", "â¢"\).*= 1234} == 1}
+ #ifndef LONGDOUBLETEST_DISABLE
{{^wcstold\("1234â¢", "â¢"\).*= 1234} == 1}
+ #endif
{{^wcstol\("1234â¢", "â¢", 10\).*= 1234} == 1}
{{^wcstoll\("1234â¢", "â¢", 10\).*= 1234} == 1}
{{^wcstoul\("1234â¢", "â¢", 10\).*= 1234} == 1}
--
2.10.4
_______________________________________________
Ltrace-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel
