On 2014-09-14 11:16:52 -0500, Jakob Unterwurzacher wrote: > ldm now reads the full output from ssh even if it dies on the way. > Proper error messages are logged and displayed, wrapped in _() so > they can be localized.
Thanks for the (updated) patch! It's an issue that's long been a thorn in the side of many users. Apologies for not getting back to you sooner on this. We unfortunately don't have a lot of active developers who understand a patch of this size; ldm has largely been in maintenance mode for quite some time. Would it be possible to usefully break this into maybe 2-4 smaller patches, and submit to the (old) launchpad bug? That might make it a little easier to review. > Messages we get: > * Permission denied (publickey,password). > The common case of a password typo or invalid user. > We make sure we read all the output BEFORE checking if the child has > died. Also, we handle EINTR, as this is what select() returns when it > gets SIGCHLD. > > * ssh: connect to host server port 22: Connection timed out > For that to work, ConnectTimeout=10 is set on the ssh command line. > Otherwise the 30 second timeout elapses before ssh tells us what is > going on. What controls the 30 second timeout? Where exactly does it occur? > * ssh: connect to host server port 22: Connection refused > That message contains a ": " like the password prompt. This is solved > by waiting for 200ms of silence before searching for the prompt (polling > interval reduced from 1s to 200ms to not bore the user). > In the error case, ssh will have exited in the meantime, and we know > for sure that it was NOT a password prompt. The last time we tried parsing the output like this, it turned out that the messages returned via ssh were highly variable depending on distro and local configuration. Maybe your code handles this no worse than the current code; I can't really say. live well, vagrant
pgpgMqfsH5R9x.pgp
Description: PGP signature
------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_____________________________________________________________________
Ltsp-discuss mailing list. To un-subscribe, or change prefs, goto:
https://lists.sourceforge.net/lists/listinfo/ltsp-discuss
For additional LTSP help, try #ltsp channel on irc.freenode.net
