release coming up soon... But probably not until next week... Doing a handover of another project right now.
/Nils -----Original Message----- From: Mathieu Desnoyers [mailto:[email protected]] Sent: den 5 maj 2011 20:37 To: David Goulet Cc: [email protected] Subject: Re: [ltt-dev] [UST PATCH] Fix dynamic link with safe snprintf * David Goulet ([email protected]) wrote: > This is why forgetting email makes me look bad after all :P > > It is fixed yes! Let's release 0.13 :D ;) OK. Let's just not advertise the MIPS support yet, because I'm still awaiting news from Jason Wessel on his testing on MIPS before I pull his patches into URCU. I'm OK for a release too. Nils ? Thanks, Mathieu > > Cheers > David > > On 11-05-05 02:23 PM, Mathieu Desnoyers wrote: >> * David Goulet ([email protected]) wrote: >>> This email was in a "time vortex"... >>> >>> Right now, the libustctl is using macro from usterr.h and those >>> macros are using the extern ust_safe_snprintf symbol. >>> >>> So, any outside program linking with libustctl (-lustctl) must have >>> libust... This cause problem with lttng-tools which is NOT link with >>> libust. >>> >>> This patch is a quick fix for this problem. >> >> See commit >> >> commit 30ffe2794fc413035208cdd2a7a061bc208e210f >> Author: Nils Carlson<[email protected]> >> Date: Mon Apr 4 12:49:56 2011 +0200 >> >> Make only libust and libustconsumer use a signal safe usterr.h >> >> Copy usterr.h to usterr_signal_safe.h and rewrite those parts of >> usterr.h that depended on libustsnprintf. This removes the dependency >> on libustsnprintf from all parts of ust except libust. >> >> This should therefore remove the dependency on libustsnprintf for >> libustctl in the git HEAD. Can you double-check ? >> >> Thanks, >> >> Mathieu >> >>> >>> Cheers >>> David >>> >>> On 11-03-28 06:02 PM, Mathieu Desnoyers wrote: >>>> * David Goulet ([email protected]) wrote: >>>>> -----BEGIN PGP SIGNED MESSAGE----- >>>>> Hash: SHA1 >>>>> >>>>> We need that in order for libustctl to be compiled with other >>>>> stuff (like liblttngctl :)) without linking libust with it. This >>>>> way, libustctl is "standalone" and no need for other library linking. >>>>> >>>>> Maybe I should add that to the commit message ;). >>>> >>>> Can you also specify which symbols from libustsnprintf you are using ? >>>> >>>> This would help us decide if it's better to remove dependency on >>>> these symbols or merge your patch. >>>> >>>> Thanks, >>>> >>>> Mathieu >>>> >>>>> >>>>> Thanks >>>>> David >>>>> >>>>> On 11-03-28 05:07 PM, Nils Carlson wrote: >>>>>> >>>>>> On Mar 28, 2011, at 8:59 PM, David Goulet wrote: >>>>>> >>>>>>> Signed-off-by: David Goulet<[email protected]> >>>>>>> --- >>>>>>> libustctl/Makefile.am | 3 ++- >>>>>>> 1 files changed, 2 insertions(+), 1 deletions(-) >>>>>>> >>>>>>> diff --git a/libustctl/Makefile.am b/libustctl/Makefile.am index >>>>>>> bc7526b..153a5bd 100644 >>>>>>> --- a/libustctl/Makefile.am >>>>>>> +++ b/libustctl/Makefile.am >>>>>>> @@ -9,6 +9,7 @@ libustctl_la_SOURCES = \ libustctl_la_LDFLAGS = >>>>>>> -no-undefined -version-info 0:0:0 >>>>>>> >>>>>>> libustctl_la_LIBADD = \ >>>>>>> - $(top_builddir)/libustcomm/libustcomm.la >>>>>>> + $(top_builddir)/libustcomm/libustcomm.la \ >>>>>>> + $(top_builddir)/snprintf/libustsnprintf.la >>>>>> >>>>>> Why do we need this link? What calls does libustctl make into >>>>>> libustsnprintf? >>>>>> >>>>>> /Nils >>>>>> >>>>>>> >>>>>>> libustctl_la_CFLAGS = -DUST_COMPONENT="libustctl" >>>>>>> -fno-strict-aliasing >>>>>>> -- >>>>>>> 1.7.4.2 >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> ltt-dev mailing list >>>>>>> [email protected] >>>>>>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev >>>>>> >>>>> >>>>> - -- >>>>> David Goulet >>>>> LTTng project, DORSAL Lab. >>>>> >>>>> 1024D/16BD8563 >>>>> BE3C 672B 9331 9796 291A 14C6 4AF7 C14B 16BD 8563 -----BEGIN PGP >>>>> SIGNATURE----- >>>>> Version: GnuPG v1.4.10 (GNU/Linux) >>>>> >>>>> iEYEARECAAYFAk2Q+U8ACgkQSvfBSxa9hWOoPgCbBPQHaMhlWZLEDZFxqH2uCdQL >>>>> ZD4An2HiCoFdaTw1jtTy+iw0/MfN13Ul >>>>> =2skp >>>>> -----END PGP SIGNATURE----- >>>> >>> >>> -- >>> David Goulet >>> LTTng project, DORSAL Lab. >>> >>> PGP/GPG : 1024D/16BD8563 >>> BE3C 672B 9331 9796 291A 14C6 4AF7 C14B 16BD 8563 >> > > -- > David Goulet > LTTng project, DORSAL Lab. > > PGP/GPG : 1024D/16BD8563 > BE3C 672B 9331 9796 291A 14C6 4AF7 C14B 16BD 8563 -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com _______________________________________________ ltt-dev mailing list [email protected] http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev _______________________________________________ ltt-dev mailing list [email protected] http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
