* Mathieu Desnoyers ([email protected]) wrote:
> * Lai Jiangshan ([email protected]) wrote:
> > Signed-off-by: Lai Jiangshan <[email protected]>
> > ---
> > urcu-call-rcu-impl.h | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/urcu-call-rcu-impl.h b/urcu-call-rcu-impl.h
> > index 65c1c7a..3c68ae7 100644
> > --- a/urcu-call-rcu-impl.h
> > +++ b/urcu-call-rcu-impl.h
> > @@ -686,6 +686,12 @@ void call_rcu_after_fork_child(void)
> > default_call_rcu_data = NULL;
> > (void)get_default_call_rcu_data();
>
> We should probably free the old default_call_rcu_data before ? and
> remove it from the call_rcu_data_list ? What about the cds queues
> content ?
>
> >
> > + /* Cleanup call_rcu_data pointers before used */
> > + maxcpus = 0;
> > + free(per_cpu_call_rcu_data);
>
> Shouldn't we clean the cds queues and remove it from call_rcu_data_list
> too ?
>
> > + per_cpu_call_rcu_data = NULL;
> > + thread_call_rcu_data = NULL;
>
> Same question applies to thread_call_rcu_data.
Forget it, I see the
/* Dispose of all of the rest of the call_rcu_data structures. */
cds_list_for_each_entry_safe(crdp, next, &call_rcu_data_list, list) {
iteration that follows. It takes care of my concerns.
Thanks,
Mathieu
>
> Thanks,
>
> Mathieu
>
> > +
> > /* Dispose of all of the rest of the call_rcu_data structures. */
> > cds_list_for_each_entry_safe(crdp, next, &call_rcu_data_list, list) {
> > if (crdp == default_call_rcu_data)
> > --
> > 1.7.4.4
> >
>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
ltt-dev mailing list
[email protected]
http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
