* David Goulet ([email protected]) wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hey, > > Merged upstream! > > I'm still considering if I "can" put it in the stable-2.0 branch since this > basically change the lttng.h ABI ...
The "enabled" field is almost never used, and having "-1" in a uint32_t is not really nice, and it is shown to the API user in the list tracepoints API. So I think it needs fixing in stable-2.0, and it should not cause any problem, just maybe fix some odd pretty-printing issue of "-1" some might have. Thanks, Mathieu > > Thanks! > David > > On 08/06/12 10:19 AM, Danny Serres wrote: > > Signed-off-by: Danny Serres <[email protected]> --- > > include/lttng/lttng.h | 2 +- 1 file changed, 1 insertion(+), 1 > > deletion(-) > > > > diff --git a/include/lttng/lttng.h b/include/lttng/lttng.h index > > 3b1be61..c80e282 100644 --- a/include/lttng/lttng.h +++ > > b/include/lttng/lttng.h @@ -214,7 +214,7 @@ struct lttng_event { enum > > lttng_loglevel_type loglevel_type; int loglevel; > > > > - uint32_t enabled; + int32_t enabled; /* Does not apply: -1 > > */ pid_t pid; > > > > char padding[LTTNG_EVENT_PADDING1]; > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.12 (GNU/Linux) > > iQEcBAEBAgAGBQJP1jiwAAoJEELoaioR9I02DmgIAI5JS3wQCwoBOIxKJz4GkA2+ > QC7AEtCRKfG6AGPi3MN7EGav+hCTHAxfGK3CWr3CDi/Vo7uE3ofZ6wI3HgTdF1aH > rEZPho96hhvsdu5p33HGg1BHuKhteYKa/TukzURBRPlu0+ruDol0rFsJn/SXblTe > WczjFTRku+EAmF55V+gXOwhZ0wazZ47lcKIIg5EZMuSQo5PsRh/OD+w5j+15+2QP > nHCFzEWEevnKmfmlhSfi0voyvNlxLzmc9ppv0AWUYX5mbppL6aCjHVu+RUphAAL4 > R2D+C6ApRQOWnn+pFj3SALxas3sWuDHDCDCXSesjCWYT5wRoM6wY/ykgETC3Q+U= > =sPTt > -----END PGP SIGNATURE----- > > _______________________________________________ > lttng-dev mailing list > [email protected] > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
