On 2013-03-25 10:30, David Goulet wrote:> Hi, > > Two things. First, the version.h.tmpl has to be added to EXTRA_DIST in > include/Makefile.am
Done. And changed the "version.h" to "nodist_*_headers". > Second thing, on line 86 of lttng.c, *never* *never* *never* pass a > variable to printf without a format. > > fprintf(ofp, lttng_version); > > This is a huge vector attack to format strings. Furthermore, outside of > the git tree, there is a warning: > > lttng.c:86:2: warning: zero-length gnu_printf format string > [-Wformat-zero-length] My mistake, forgot to correct that... It's ok in the new patch. Raphaël
signature.asc
Description: OpenPGP digital signature
_______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
