Hey guys, Thanks for the help, I just submitted Fix #453 for a review, hopefully I did it correct. *fingers crossed*
I'll be submitting fixes for #488 in a few hours. Thanks again, Simar On Tue, Apr 9, 2013 at 12:08 PM, David Goulet <[email protected]> wrote: > Hi Simarpreet, > > Can you please rebase your branch on the HEAD of the master branch of > lttng-tools before sending a pull request. > > Also, when you fix a bug in the tracker, use "Fix:" with a meaningful > message, add "Fixes #xxx" at the end and finally your signed-off message > like so: > > --- > > Fix: [...] > > [more info if necessary] > > Fixes #xxx > > Signed-off-by: YOUR_NAME <YOUR_EMAIL> > > --- > > Apart from those aesthetics fix, thanks a lot for the contribution. I'll > wait for your fixes to pull back the commits. > > Cheers! > David > > Simarpreet Singh: > > Hello again, > > > > Sorry for the emails guys, I fixed a bunch of other typos in the > > codebase, I think these shall go under Bug #488. > > > > Bug URL: http://bugs.lttng.org/issues/488 > > > > Fix: > https://github.com/simar7/lttng-tools/commit/6a6df32f6fadcb85a275b8ea93306af2d498c263 > > > > I've pushed my changes on my github account, I'll try to figure out the > > correct way to file them in the meantime. > > > > > > Thanks, > > Simar > > > > > > This body part will be downloaded on demand. >
_______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
