We can't merge that for UST. However, it needs to be done on the kernel side! Removing it from the add_stream did impact the kernel. This is a good fine but should not be done there.
See commit: b31398bb2b3fa91a53dea3b36fd693da4b50e0d3 David Mathieu Desnoyers: > * Julien Desfossez ([email protected]) wrote: >> Signed-off-by: Julien Desfossez <[email protected]> > > check the impact on the ust side ? > >> --- >> src/common/consumer.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/src/common/consumer.c b/src/common/consumer.c >> index c9e4bae..bfb809a 100644 >> --- a/src/common/consumer.c >> +++ b/src/common/consumer.c >> @@ -663,6 +663,9 @@ static int add_stream(struct lttng_consumer_stream >> *stream, >> uatomic_inc(&relayd->refcount); >> } >> >> + /* Update channel refcount once added without error(s). */ >> + uatomic_inc(&stream->chan->refcount); >> + >> /* >> * When nb_init_stream_left reaches 0, we don't need to trigger any >> action >> * in terms of destroying the associated channel, because the action >> that >> -- >> 1.7.10.4 >> >> >> _______________________________________________ >> lttng-dev mailing list >> [email protected] >> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev > _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
