In lttng-tools/src/bin/lttng/lttng.c, the check_args_no_sessiond function checks the command-line arguments for "specific options and commands that must not trigger a session daemon". The function detects the options "-h", "--h" (for "--help"), "--list-options", and "--list-commands", and the commands "version" and "view".
The parse_args function, on the other hand, detects "-V", "-h", "--list-commands", "--list-options" at its outset and *does not* reach the session daemon spawning check ( if (opt_no_sessiond == 0 && check_args_no_sessiond(argc, argv) == 0 && (check_sessiond() < 0)) ) in those cases. So, why is check_args_no_sessiond checking for options at all? Considering the control flow of parse_args, check_args_no_sessiond should check *only* for the "version" and "view" commands. If check_args_no_sessiond is to check the command-line options anyway (for completeness's sake, say), then it should check for the "-V"/"--version" option as well. And if the check for "--h" is satisfactory, the check for "--list-commands" and "--list-options" should be collapsed into a simple check for "--l". (These observations are based on the May 23 commit, so my apologies if these points have already been addressed) Daniel U. Thibault Protection des systèmes et contremesures (PSC) | Systems Protection & Countermeasures (SPC) Cyber sécurité pour les missions essentielles (CME) | Mission Critical Cyber Security (MCCS) R & D pour la défense Canada - Valcartier (RDDC Valcartier) | Defence R&D Canada - Valcartier (DRDC Valcartier) 2459 route de la Bravoure Québec QC G3J 1X5 CANADA Vox : (418) 844-4000 x4245 Fax : (418) 844-4538 NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ> Gouvernement du Canada | Government of Canada <http://www.valcartier.drdc-rddc.gc.ca/> _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
