* Ikaheimonen, JP ([email protected]) wrote: > Hi, > > here is the new patch set that makes it possible to compile Babeltrace on > MinGW32. > I have taken your previous comments into account wherever possible. > > This patch set requires the patch I sent earlier, titled " [Babeltrace PATCH > 01/01] Move strerror_r to compat directory " , and should be applied on top > of that. > > Some notes: > > MinGW, especially MinGW32, is very lacking in library functions. (Indeed, > 'minimal'). > Some functions that are found in Microsoft Visual Studio run time libraries > are not accessible in MinGW32. > These include any *_s functions such as strerror_s, gmtime_s, localtime_s and > strtok_s; also strnlen is conspicuously missing. > No byte-swapping function, either. > > It would have been possible to link to those functions dynamically, finding > the function address from the DLL etc, > but I'm not doing it, because in the end, my goal is to create a statically > linked tool, with minimal dependencies to shared libraries. > That is why, instead of using a well-known library function, I have resorted > to implementing one on my own. > > I'm still open for any comments that you might have.
I'll go through the patchset. First note: you forgot to add your Signed-off-by line to your patches (please do for next patches). Thanks, Mathieu > > Thanks, > > JP Ikaheimonen | SW Development Engineer http://go.mentor.com/sourceryanalyzer > > Mentor Embedded(tm) | Nucleus(r) | Linux(r) | Android(tm) | Services | UI | > Multi-OS > > Android is a trademark of Google Inc. Use of this trademark is subject to > Google Permissions. > Linux is the registered trademark of Linus Torvalds in the U.S. and other > countries. -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
