----- Original Message ----- > From: "Raphaël Beamonte" <[email protected]> > To: "Mathieu Desnoyers" <[email protected]> > Cc: "David Goulet" <[email protected]>, [email protected] > Sent: Wednesday, November 13, 2013 10:27:03 PM > Subject: Re: [lttng-dev] [lttng-tools PATCH 3/4] Correct the behavior of the > utils_expand_path function > > > I might be missing something, but how about, instead: > > > > 1) if path start with /, directly pass it to realpath() > > 2) if path does not start with /, prepend getcwd() to it, and then call > > realpath() on the result. > > > > If we can do the same result as this patch without reimplementing tricky > > string handling, we should really aim for re-using existing libraries. > > > > Thoughts ? > > Hello Mathieu, > > Thing is realpath only works if the path exists (realpath(3)). I > perhaps want to give as argument an absolute path that does not exist, > or a path containing strings such as '../' or './'. In such cases, > realpath would do no good, and if we don't accept to use unexisting > paths, then there is no point in using a recursive mkdir. > If fact, if realpath would work in such cases, using an 'if' would not > even be necessary, we could just call realpath and let it resolve the > current directory if necessary. > > Hope it helps to understand,
Yes, it does, thank you! Mathieu > > Raphaël > -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
