----------------------------------------------------------------------
Date: Thu, 10 Apr 2014 11:30:19 -0400
From: Simon Marchi <[email protected]>
+++ b/src/common/utils.c
@@ -650,42 +649,10 @@ error:
[...]
* The suffix multiply the integer by:
>>> Should be "The suffixes multiply the integer by:"
@@ -693,83 +660,94 @@ static void regex_print_error(int errcode, regex_t *regex)
[...]
+ /* strtoull will accept a negative number, but we don't want to. */
+ if (strchr(str, '-') != NULL) {
+ DBG("utils_parse_size_suffix: invalid size string, should not
contain '-'.");
ret = -1;
+ goto end;
}
>>> Should be "[...] should not begin with '-' [...]" (although it is true
>>> the size string should not *contain*, the test is only for *begins with*)
[...]
+ if (num_end == str) {
+ /* strtoull parsed nothing, not good. */
+ DBG("utils_parse_size_suffix: strtoull had nothing good to
parse.\n");
+ ret = -1;
+ goto end;
+ }
>>> "utils_parse_size_suffix: zero-length size string." would be clearer.
>>> Also note that the preceding DBG strings did not end with '\n'.
+ /* Check if a prefix is present. */
>>> That should be "suffix".
[...]
+ default:
+ DBG("utils_parse_size_suffix: invalid suffix.\n");
>>> Another DBG string with a superfluous trailing '\n'.
Daniel U. Thibault
Protection des systèmes et contremesures (PSC) | Systems Protection &
Countermeasures (SPC)
Cyber sécurité pour les missions essentielles (CME) | Mission Critical Cyber
Security (MCCS)
R & D pour la défense Canada - Valcartier (RDDC Valcartier) | Defence R&D
Canada - Valcartier (DRDC Valcartier)
2459 route de la Bravoure
Québec QC G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ>
Gouvernement du Canada | Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
