On Tue, Oct 28, 2014 at 12:02 AM, Nathan Lynch <[email protected]> wrote:
> On 10/27/2014 09:38 PM, Jonathan Rajotte wrote: > > Hey > > > > On Mon, Oct 27, 2014 at 10:00 PM, Nathan Lynch <[email protected] > > <mailto:[email protected]>> wrote: > > > > An argument of "$2" was added to the prove command line in > > tests/run.sh by 68270f0f604e "Mi test: Basic test structure". This > is > > harmless since run.sh is never called with more than one argument, > but > > > > > > The multiple arguments could be overcome by adding "" to the multiple > > test files list but as you said it is confusing and error prone. > > > > This actually can be used to debug test with a "-v". Or add any basic > > arguments to the prove command and was simply convenient at the time.If > > this actually break patch from OE ( I assume OE stand for OpenEmbedded > > and you are talking about this commit [1]) I'm okai with reverting the > > change I introduced. > > I didn't intend to imply that upstream LTTng is responsible for keeping > patches working in a downstream project like OE. I mentioned OE because > that's how my attention was drawn to this change. Did not take it like that :) > > If the $2 argument has a legitimate use, I suggest that it be made a bit > more clear since 1) the commit that introduced it didn't mention it at > all, and 2) no code in-tree actually makes use of the extra argument. > > I figured it was likely a mistake. > Which kind of was. This wasn't supposed to be merge and was a mistake on my part when formatting the patch. It was discussed with David before merging and we decided to keep it since it was not harmful or *used* and proved useful. But with the effect it has and unwanted repercussion(confusion, missing mention in commit etc.) it seems not every aspect where evaluated. Hence I don't mind this patch and almost welcome it. Cheers! -- Jonathan R.Julien
_______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
