On Tue, Jan 6, 2015 at 6:09 PM, Mathieu Desnoyers
<[email protected]> wrote:
> ----- Original Message -----
>> From: "Jérémie Galarneau" <[email protected]>
>> To: "Mathieu Desnoyers" <[email protected]>
>> Cc: "Jeremie Galarneau" <[email protected]>, [email protected]
>> Sent: Tuesday, January 6, 2015 3:59:53 PM
>> Subject: Re: [PATCH lttng-tools 11/13] Refactor sessiond
>> main/cleanup/ht-cleanup
>>
>> > diff --git a/src/bin/lttng-sessiond/ht-cleanup.c
>> > b/src/bin/lttng-sessiond/ht-cleanup.c
>> > index 0469f92..79fb9cd 100644
>> > --- a/src/bin/lttng-sessiond/ht-cleanup.c
>> > +++ b/src/bin/lttng-sessiond/ht-cleanup.c
>> > @@ -47,7 +47,7 @@ void *thread_ht_cleanup(void *data)
>> >
>> > health_code_update();
>> >
>> > - ret = sessiond_set_thread_pollset(&events, 2);
>> > + ret = sessiond_set_ht_cleanup_thread_pollset(&events, 2);
>>
>> Won't this result in adding the ht_cleanup_quit_pipe twice to the
>> pollset? (see line 56 in
>> lttng-tools/src/bin/lttng-sessiond/ht-cleanup.c)
>
> No. ht_cleanup_quit_pipe and ht_cleanup_pipe are two different
> pipes.
>
Right! Thanks for the clarification.
Jérémie
> [...]
>
>> >
>> > - DBG("Cleaning up");
>> > + DBG("Cleanup up sessiond");
>>
>> Slight typo here. I'll fix it on my end.
>
> ok
>
> Thanks!
>
> Mathieu
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
