Merged, with title edit. ;-) Thanks,
Mathieu ----- On Sep 21, 2015, at 2:31 PM, Jonathan Rajotte [email protected] wrote: > Reported by cppcheck [1]. > > [1] > https://ci.lttng.org/view/Code%20quality/job/lttng-ust_master_cppcheck/5/cppcheckResult/source.10/ > > Proposed-by: Michael Jeanson <[email protected]> > Signed-off-by: Jonathan Rajotte <[email protected]> > --- > libringbuffer/backend_internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libringbuffer/backend_internal.h > b/libringbuffer/backend_internal.h > index 344784f..79f8bde 100644 > --- a/libringbuffer/backend_internal.h > +++ b/libringbuffer/backend_internal.h > @@ -485,7 +485,7 @@ static inline int lttng_ust_fls(unsigned int x) > r -= 2; > } > if (!(x & 0x80000000U)) { > - x <<= 1; > + /* No need to bit shift on last operation */ > r -= 1; > } > return r; > -- > 2.1.4 -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
