On 2016-04-28 14:28, Michael Jeanson wrote:
----- On Apr 28, 2016, at 12:44 PM, Simon Marchi
[email protected] wrote:
Ok thanks.
Just an idea: I find it quite cumbersome to add a new entry in
configure.ac for each test script that we want autoconf to process
(such
as in patch 3/3). I think it could be easier to have a single file
(e.g. vars.sh) and have it contain definitions of various directories:
srcdir=@srcdir@
top_srcdir=@top_srcdir@
abs_top_srcdir=@abs_top_srcdir@
builddir=@builddir@
...
This way, you could have only a single generated file (vars.sh.in ->
vars.sh), and each test script would just have to source that file to
use the values.
As discussed on #lttng, here is the PR resulting from my updates to
your
patches :
https://github.com/efficios/babeltrace/pull/43
Thanks for following up.
Concerning the include file, I'm not convinced it would be simpler, we
would
end up with static scripts in the source dir including a generated file
in
the builddir.
In the current state, even the static scripts are copied to the build
dir, so it
wouldn't be a problem. Anyway, if it's not a problem, I think it looks
good in your
PR.
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
