On 1 June 2017 at 17:30, Dávid Beck <[email protected]> wrote: > Hi Jérémie, > > Sounds great, thank you! > > I had a quick look into this pull request and I haven’t found how this > relates the issues I found: > > 1, HOST_NAME_MAX was not defined > 2, errno.h was needed on Mac > > May be it is only my lack of auto tools knowledge, I don’t know. Anyways, > thank you again.
Indeed, it doesn't fix those issues directly; it disables the build of everything except the lttng-relayd on macOS in the default build configuration. I'm not sure it is worth addressing the build issues, except if someone can confirm whether or not the rest of the toolchain actually works on macOS. Thanks, Jérémie > > Best, David > > >> On 01 Jun 2017, at 22:02, Jérémie Galarneau <[email protected]> >> wrote: >> >> Hi David, >> >> The pull request Michael referenced was merged and your issue should >> be resolved in both the master and stable-2.10 branches. >> >> Jérémie >> >> On 24 May 2017 at 14:06, Michael Jeanson <[email protected]> wrote: >>> On 2017-05-24 11:11, Jérémie Galarneau wrote: >>>> >>>> Good idea! It will certainly be less error-prone. >>>> >>> >>> I added it to this [1] pull request since it's build system related. It >>> was tested on macOS 10.12.4. >>> >>> Michael >>> >>> [1] https://github.com/lttng/lttng-tools/pull/91 >>> >> >> >> >> -- >> Jérémie Galarneau >> EfficiOS Inc. >> http://www.efficios.com > -- Jérémie Galarneau EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
