On 2017-07-10 15:06, Nathan Lynch wrote: > > (This is with master hence the -pre1 reported, but the code is the same.) > > I get failures when building with BUILT_IN_PLUGINS as suggested here: > > https://lists.lttng.org/pipermail/lttng-dev/2017-June/027243.html > > Is BUILT_IN_PLUGINS intended to accomplish something that libtool cannot? > > $ ./configure --quiet --disable-shared BUILT_IN_PLUGINS=1 > Babeltrace 2.0.0-pre1 > > System > Target architecture: x86_64 > > Python 3 language support > Python bindings: no > Python plugin support: no > > Plugins > 'ctf' plugin: yes > 'lttng-utils' plugin: yes > 'text' plugin: yes > 'utils' plugin: yes > > Built-in features > Built-in plugins: yes > Built-in Python plugin support: no > > Documentation > HTML API documentation: no > Python bindings documentation: no > > Logging > Minimal log level: VERBOSE > > Testing > Python bindings tests: no > > Install directories > Binaries: /usr/local/bin > Libraries: /usr/local/lib > Plugins: /usr/local/lib/babeltrace/plugins > Configuration: /usr/local/etc > $ make > .... > Making all in cli > CCLD babeltrace.bin > /usr/bin/ld: cannot find > /home/nathanl/src/babeltrace/plugins/ctf/.libs/libbabeltrace-plugin-ctf.a: No > such file or directory > /usr/bin/ld: cannot find > /home/nathanl/src/babeltrace/plugins/text/.libs/libbabeltrace-plugin-text.a: > No such file or directory > /usr/bin/ld: cannot find > /home/nathanl/src/babeltrace/plugins/utils/.libs/libbabeltrace-plugin-utils.a: > No such file or directory > /usr/bin/ld: cannot find > /home/nathanl/src/babeltrace/plugins/lttng-utils/.libs/libbabeltrace-plugin-lttng-utils.a: > No such file or directory > collect2: error: ld returned 1 exit status > _______________________________________________ > lttng-dev mailing list > [email protected] > https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev >
Hi Nathan, This one is my fault, I forgot to stage one file when I submitted 22e7ae1917a72d89b308345b3bcb97c76362da4f. Jérémie is on vacation for the week, in the meantime you can apply the attached patch. Cheers, Michael
>From 22949ce66d5da98cd8251e3fc54b0583847a1550 Mon Sep 17 00:00:00 2001 From: Michael Jeanson <[email protected]> Date: Mon, 10 Jul 2017 15:22:39 -0400 Subject: [PATCH babeltrace stable-1.5] Fix: built-in plugins with new plugin filenames Signed-off-by: Michael Jeanson <[email protected]> --- cli/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/Makefile.am b/cli/Makefile.am index 902ad0d..5ceb499 100644 --- a/cli/Makefile.am +++ b/cli/Makefile.am @@ -64,7 +64,7 @@ if BUILT_IN_PLUGINS # binary that are filled by plugin objects. If the linker discards those # symbols because the CLI does not use them directly, the CLI reports # no plugins found (plugins are effectively not embedded). -pluginarchive = -Wl,--whole-archive,$(PLUGINS_PATH)/$(1)/.libs/libbabeltrace-plugin-$(1).a,--no-whole-archive +pluginarchive = -Wl,--whole-archive,$(PLUGINS_PATH)/$(1)/.libs/babeltrace-plugin-$(1).a,--no-whole-archive # Built-in plugins babeltrace_bin_LDFLAGS += $(call pluginarchive,ctf) -- 2.7.4
_______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
