Re: [lttng-dev] [PATCH lttng-tools 2/5] Fix: should pass the reg_enum_lookup pointer directly

[Mathieu Desnoyers]

----- On Feb 7, 2018, at 2:36 PM, Francis Deslauriers 
francis.deslauri...@efficios.com wrote:

> As the ht_hash_enum and ht_match_enum functions are not changing the
> pointer there is no need to pass the address of the pointer.

The changelog seems too nice. The current situation is that the arguments
passed to the cds_lfht_lookup() function do not match the args expected by 
ht_has_enum
and ht_match_enum, and by chance we probably always end up comparing with 
garbage ?

The changelog should better describe the current problem.

Thanks,

Mathieu

> 
> Signed-off-by: Francis Deslauriers <francis.deslauri...@efficios.com>
> ---
> src/bin/lttng-sessiond/ust-registry.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/bin/lttng-sessiond/ust-registry.c
> b/src/bin/lttng-sessiond/ust-registry.c
> index e336b9e..cd6fdac 100644
> --- a/src/bin/lttng-sessiond/ust-registry.c
> +++ b/src/bin/lttng-sessiond/ust-registry.c
> @@ -558,8 +558,8 @@ struct ust_registry_enum *
>       struct lttng_ht_iter iter;
> 
>       cds_lfht_lookup(session->enums->ht,
> -                     ht_hash_enum((void *) &reg_enum_lookup, lttng_ht_seed),
> -                     ht_match_enum, &reg_enum_lookup, &iter.iter);
> +                     ht_hash_enum((void *) reg_enum_lookup, lttng_ht_seed),
> +                     ht_match_enum, reg_enum_lookup, &iter.iter);
>       node = lttng_ht_iter_get_node_str(&iter);
>       if (!node) {
>               goto end;
> --
> 2.7.4
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev