----- On Mar 23, 2018, at 1:25 PM, Khalid Elmously [email protected] wrote:
> On 2018-03-23 13:11:28 , Mathieu Desnoyers wrote: >> ----- On Mar 23, 2018, at 11:55 AM, Khalid Elmously >> [email protected] wrote: >> >> > Starting from 4.13.0-38 the ubuntu kernel backport a kvm instrumentation >> > change introduced in 4.15 which affects the prototype of the kvm_mmio >> > event. >> > >> > Signed-off-by: Khalid Elmously <[email protected]> >> > --- >> > instrumentation/events/lttng-module/kvm.h | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/instrumentation/events/lttng-module/kvm.h >> > b/instrumentation/events/lttng-module/kvm.h >> > index 8f9a132..c419f9c 100644 >> > --- a/instrumentation/events/lttng-module/kvm.h >> > +++ b/instrumentation/events/lttng-module/kvm.h >> > @@ -92,6 +92,8 @@ LTTNG_TRACEPOINT_EVENT(kvm_ack_irq, >> > || LTTNG_KERNEL_RANGE(4,1,50, 4,2,0) \ >> > || LTTNG_KERNEL_RANGE(3,16,52, 3,17,0) \ >> > || LTTNG_KERNEL_RANGE(3,2,97, 3,3,0) \ >> > + || LTTNG_UBUNTU_KERNEL_RANGE(4,13,16,38, 4,14,0,0) \ >> > + || LTTNG_UBUNTU_KERNEL_RANGE(4,14,0,0, 4,15,0,0) \ >> >> Is it really all Ubuntu kernels from 4.14.0 to 4.15.0 that >> are affected ? I suspect that it does not start at .0. >> > > Thanks. The third number (0 in this case) comes from the upstream linux-stable > version number. If a Ubuntu 4.14.x.y kernel were ever to exist, it could > conceivably start at x = 0 if it was based directly on Linus' 4.14 tag. > > That being said, a Ubuntu 4.14.x.y kernel is only hypothetical as far as I > know > and probably won't ever exist so I have no issue with simply ignoring Ubuntu > 4.14.x.y altogether. > > Sending a v3 shortly, thanks. Indeed, we only target existing, released distro kernel versions. Otherwise it's the vanilla kernel version range that handles it. Thanks, Mathieu > > Khalid. > > > >> Thanks, >> >> Mathieu >> >> > || LTTNG_DEBIAN_KERNEL_RANGE(4,9,65,0,3,0, 4,10,0,0,0,0) \ >> > || LTTNG_FEDORA_KERNEL_RANGE(4,14,13,300, 4,15,0,0)) >> > >> > -- >> > 2.14.1 >> > >> > _______________________________________________ >> > lttng-dev mailing list >> > [email protected] >> > https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev >> >> -- >> Mathieu Desnoyers >> EfficiOS Inc. > > http://www.efficios.com -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
