----- On Jul 29, 2019, at 9:35 AM, Junchang Wang junchangw...@gmail.com wrote:

> Signed-off-by: Junchang Wang <junchangw...@gmail.com>

Hi Junchang,

Thanks for submitting this! I've been on vacation for the past two weeks,
hence the delay in reply.

A few points:

I think we should move the implementation of find/insert/delete to a .c
file (rather than headers) because at least two of those functions are
larger than 10 lines, and therefore don't fall under the "trivial"
category.

I also notice that the implementation you propose is GPLv2+. Would you
be willing to re-license your contribution under LGPLv2.1 or LGPLv2.1+ ?
This is the license we use for the entire Userspace RCU library. liburcu
is meant to be used by non-GPL/LGPL programs as well.

I'll wait until I get an answer from you on those points before digging
further into the code.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Reply via email to