On Mon, Jun 29, 2020 at 12:36:57PM -0400, Michael Jeanson wrote: > ----- On 29 Jun, 2020, at 12:26, Stefan Hajnoczi stefa...@redhat.com wrote: > > > On Fri, Jun 26, 2020 at 05:02:00PM -0400, Michael Jeanson wrote: > >> I proposed a patch here[1] that addresses this problem in a generic way by > >> duplicating the macro and namespacing it under LTTNG_. Honestly this is > >> more > >> of an sdt bug, the STAP_PROBEV should be in it's own include guard outside > >> of _SYS_SDT_H or in it's own header file but we have to work with what's > >> there. > >> > >> Can you have a look at the patch and confirm that it fixes your problem? > > > > Great, glad there is already a fix under review. > > > > When I try out the patch the application does not compile. The error > > messages are the same as without the patch because _LTTNG_SDT_PROBE() is > > not defined. Was that supposed to be _SDT_PROBE() instead? > > > > The application compiles successfully after replacing _LTTNG_SDT_PROBE() > > with _SDT_PROBE(). > > > > Stefan > > Yes indeed, I reworked the patch after testing it and didn't catch this, I've > just pushed an updated patch. Thanks for testing it and catching this.
Nice! Thanks for the fix. Stefan
signature.asc
Description: PGP signature
_______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
