On Sat, Sep 18, 2010 at 3:57 AM, Alexander Gladysh <[email protected]> wrote:
> On Sat, Sep 18, 2010 at 07:26, Alexandre Erwin Ittner
> <[email protected]> wrote:
>> Hisham <[email protected]> wrote
>
>>> Sounds like a good idea, but the "in modern versions at least" bit
>>> made me wary. (I'd prefer avoiding it if it's a recent feature,
>>> because I don't want to have to start replying "upgrade your git" to
>>> people. :) )
>
>> I do not see any big problem here, since the support for shallow clones
>> was added in Git 1.5.0 (ca. Feb 2007). It is a very long time for the
>> typical Git user and I think people used to build source rocks from the
>> VCS will not be using such an ancient version now.
>
> I do not see a problem either. (After all, it is easy to make this
> feature configurable and detect git version in ./configure.)
>
> Also, you don't want to try to support anything below Git 1.5.0. This
> is really ancient history.

Makes sense -- just comitted use of --depth=1 and removal of .git when fetching.

-- Hisham

_______________________________________________
Luarocks-developers mailing list
[email protected]
http://lists.luaforge.net/cgi-bin/mailman/listinfo/luarocks-developers

Reply via email to