On Wed, Nov 24, 2010 at 03:39, Hisham <[email protected]> wrote:

> Here's a preview release of LuaRocks 2.0.4. This is a release
> candidate: if no problems are reported, these packages will be renamed
> into the final versions.

I'm back with some feedback.

1. What about these commits from Steve's repo?

1.1. 
https://github.com/stevedonovan/luarocks/commit/f3a33fbf845dfbb97b66767316b42974fd894884

> Extra top-level field for rockspec called 'meta'. It can be any arbitrary
> Lua table structure and is intended for attaching metadata to rockspecs.

I'm not sure I like the design of it, but I need to attach metadata to
my rockspecs (a Git commit ID from which rockspec was built), and it
should do the job.

Instead of this I would prefer to have "x-<something>" fields (for
example, "x-git-commit-sha") to be allowed at any place of the
rockspec, so I would be able to keep metadata close to the data it
related to.

I can produce a patch for this if it has a chance to get into the trunk.

1.2. 
https://github.com/stevedonovan/luarocks/commit/8d6055558e9de024f732037e9f103b28c8c90317

> The make command now supports a --path=dir flag.

This would be useful in my build scripts.

1.3. 
https://github.com/stevedonovan/luarocks/commit/a6a9123b7d36c73495388ecb2bc99850a51165e1

> Machine-friendly output from luarocks list with the --line flag.
> This will give tab-separated columns name,version,repo.

Hisham, please, can you merge this into 2.0.4? I really need that one.

1.4. 
https://github.com/stevedonovan/luarocks/commit/30cdd3c7523c50083a616a3357946a7f33dc0ae2

> Added pre_install hook; this is called directly after dependencies have
> been satisfied and we are starting the install. The rockspec variable
> LAST_VERSION is also set if there was a previous version; if this variable
> is the same as the rockspec version, then this was a re-install.

I'll need something like this in the long run for my deployment process.

2. I've just run deployment locally with 2.0.4-rc2, all seems to be OK.

Thanks,
Alexander.

P.S. I'll try to return with more feedback on other features.

_______________________________________________
Luarocks-developers mailing list
[email protected]
http://lists.luaforge.net/cgi-bin/mailman/listinfo/luarocks-developers

Reply via email to