On Fri, Mar 4, 2011 at 3:43 AM, Robert G. Jakabosky <[email protected]> wrote: > When installing from a rockspec that checks out from a git repository, > LuaRocks removes the '.git' subfolder breaking the cloned git repository. > This is a problem when there are submodules in a parent git repository that > need to be pull into during build. > > I have a fork of the lua-http-parser [1] project that I was testing some > changes on when I ran into this problem. It seems that this wasn't a problem > with LuaRocks 2.0.4, it only started happening with 2.0.4.1. > > Why is the '.git' subfolder removed?
Ouch. Because someone asked me to remove it. Sounded like a good idea, to avoid bloating .src.rock files. It still does, and I would hate to have to add a source.keep_git flag or something to the rockspec format, but if there's no other way to build it properly... A question: does lua-http-parser only do git-pull during build when using scm rocks or does it do the same with release versions? Requiring internet access during build wouldn't be what I'd call a good practice. In any case, to workaround the issue right now you can remove the two fs.delete() commands near the end of luarocks/fetch/git.lua. I'll think of a permanent solution. -- Hisham _______________________________________________ Luarocks-developers mailing list [email protected] http://lists.luaforge.net/cgi-bin/mailman/listinfo/luarocks-developers
